Comments on: codejam, groovy, and refactoring http://imnotpete.com/2008/07/19/codejam-groovy-and-refactoring/ Fri, 21 Nov 2008 04:33:15 +0000 http://wordpress.org/?v=2.6 By: sam http://imnotpete.com/2008/07/19/codejam-groovy-and-refactoring/#comment-850 sam Sun, 20 Jul 2008 15:46:59 +0000 http://imnotpete.com/2008/07/19/codejam-groovy-and-refactoring/#comment-850 That is clearer, thanks. I also went ahead and went from <code> new Integer(i.next()).times() { </code> to <code> i.next().toInteger().times() { </code> That is clearer, thanks. I also went ahead and went from
new Integer(i.next()).times() {
to
i.next().toInteger().times() {

]]> By: James Lorenzen http://imnotpete.com/2008/07/19/codejam-groovy-and-refactoring/#comment-849 James Lorenzen Sun, 20 Jul 2008 10:09:49 +0000 http://imnotpete.com/2008/07/19/codejam-groovy-and-refactoring/#comment-849 I got curious so I took at look at your code. Looks excellent. Good work. I made a couple of changes, nothing major just some personal preference. Here is the diff http://pastebin.com/pastebin.php?diff=f22de2081 The main thing is I like declaring lists using the literal like engines = [] vs engines = new ArrayList() I got curious so I took at look at your code. Looks excellent. Good work.
I made a couple of changes, nothing major just some personal preference. Here is the diff http://pastebin.com/pastebin.php?diff=f22de2081

The main thing is I like declaring lists using the literal like
engines = []
vs
engines = new ArrayList()

]]> By: James Lorenzen http://imnotpete.com/2008/07/19/codejam-groovy-and-refactoring/#comment-848 James Lorenzen Sun, 20 Jul 2008 10:01:18 +0000 http://imnotpete.com/2008/07/19/codejam-groovy-and-refactoring/#comment-848 This is great Sam. Good job. Keep us updated. This is great Sam.
Good job. Keep us updated.

]]>